PedestrianDynamics / jupedsim

JuPedSim is an open source pedestrian dynamics simulator
http://jupedsim.org
Other
41 stars 28 forks source link

bug with high num_threads (2/2): Wrong 'index' in CBuiling::GetRoom() Room ID #213

Closed chraibi closed 5 years ago

chraibi commented 5 years ago

In Gitlab by @chraibi on Jun 22, 2016, 15:13 [origin]

I've encountered severe issues, when increasing num_threads to higher orders e.g. 24. Despite I have carefully checked my geometry file, I randomly get the following error:


        Control your rooms ID and make sure they are in the order 0, 1, 2,..```

The very concerning thing is that this somehow depends on num_threads. When using num_threads=24 it works. With 12 it does not.

@Arne @OSchmidts @chraibi Does someone of you have an idea about that? FYI: The Hermes Cluster is available again and could be used for reproducing that. I've attached exemplary files.

[room_id.zip](https://gitlab.version.fz-juelich.de/JuPedSim/jpscore/uploads/9a79fdcf65b24033849a3f9ca29108f4/room_id.zip)
chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

closed

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by b.schroeder on 22 Jun 2016, 13:16


mentioned in commit 023867a8db2e4602e966a3b56036772b79d5c94d

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by chraibi on 29 Jun 2016, 13:14


Status changed to closed by commit 19a55d393858dd40c3b30cab3ffba315b48615e2

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by chraibi on 29 Jun 2016, 13:16


@schroederbenjamin issue 200 is closed. Please check if this error is still occurring.

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by chraibi on 29 Jun 2016, 19:55


mentioned in commit 19a55d393858dd40c3b30cab3ffba315b48615e2

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by b.schroeder on 29 Jun 2016, 23:06


@chraibi this error still persists :(

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by chraibi on 30 Jun 2016, 01:55


Ok. Looks like an initialisation error. I ll check.. :dragon_face:

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by chraibi on 14 Jul 2016, 16:22


@schroederbenjamin Does this error occur sporadically or by every simulation?

I just tried and had no problems. (on branch issue_202)

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by chraibi on 17 Jul 2016, 14:02


Beni, should we close this? With develop after closing issue #202 I could not reproduce it anymore.

chraibi commented 5 years ago

In Gitlab by @chraibi on Dec 17, 2016, 12:09

Original comment by b.schroeder on 17 Jul 2016, 18:36


Yeah... If necessary we could reopen