PediatricOpenTargets / OpenPedCan-api

2 stars 7 forks source link

Update API database using OpenPedCan-analysis v12 final release data #87

Closed logstar closed 1 year ago

logstar commented 1 year ago

Updated API database using OpenPedCan-analysis v12 final release data. The following filtered files in s3://d3b-openaccess-us-east-1-prd-pbta/open-targets/v12/api-data/ were used for building the API database:

The filtered files were generated by the filter-mtp-tables module in the OpenPedCan-analysis.

Resolved #86

Type of change

Changed

Added

How Has This Been Tested?

Terminal returns for testing DEV host:

$ API_HOST=dev ./tests/run_tests.sh
API base URL: https://openpedcan-api-dev.d3b.io
✔ |  OK F W S | Context
✔ | 885       | tests/r_test_scripts/test_endpoint_http.R [3952.2 s]

══ Results ════════════════════════════════════════════
Duration: 3952.2 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 885 ]
Done running run_tests.sh

For more details about testing environment, options, and resources, see README.md.

Checklist

logstar commented 1 year ago

Hi @kelseykeith . Thank you for reviewing the PR.

I was wondering if the lsb-release issue could be addressed in a separate issue/PR. The current v12 final-release database was built on an ubuntu EC2 instance without installing lsb-release in the db/build_tools/build_db.Dockerfile. The lsb-release error might need to be reproduced with major changes to the local v12 final-release database building environment, such as docker version, docker image version, and operating system version. The local building environment changes might cause additional dependency issues. Therefore, I was wondering if it might be more efficient to resolve the lsb-release issue in a standalone PR, or a PR that starts development with the lsb-release installed.

kelseykeith commented 1 year ago

Yes, I'm fine with that. I can either submit a standalone PR for the issue or include it with my CNV database PR once we get there

logstar commented 1 year ago

Thank you. I will also add lsb-release installation to the db/build_tools/build_db.Dockerfile before working on the next issue.

I will merge this PR soon to update the QA API site.