search

PedroBern / django-graphql-auth

Django registration and authentication with GraphQL.
https://django-graphql-auth.readthedocs.io/en/latest/
MIT License
326 stars 105 forks source link

Update dependencies: PyJWT and django-graphql-jwt #121

Open lucmult opened 3 years ago

lucmult commented 3 years ago

Currently other JWT libraries that used with django-graphql require PyJWT > 2.0, e.g: django-graphql-jwt

Remove PyJWT from the dependencies from django-graphsql-auth is safe because this isn't imported directly here.

Upgraded django-graphql-jwt from 0.3.0 to 0.3.2.

I've run the following tests locally:

$ make test
...
  py38-django30: commands succeeded
  congratulations :)

Lint and format run locally too.

lucmult commented 3 years ago

This should fix #111

amorino commented 3 years ago

This is great.

cadiente-jomel commented 2 years ago

@PedroBern can you merge this PR?

pors commented 2 years ago

Did you actually get it to install? I cloned it with your modifications and did:

cd django-graphql-auth
pip install -e .

result:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gql 2.0.0 requires graphql-core<3,>=2.3.2, but you have graphql-core 3.1.7 which is incompatible.
Successfully installed PyJWT-2.3.0 aniso8601-9.0.1 django-graphql-auth-0.3.16 django-graphql-jwt-0.3.2 graphene-3.0 graphene_django-3.0.0b7 graphql-core-3.1.7 graphql-relay-3.1.5
PabloCastellano commented 2 years ago

Please, can we get this trivial PR merged? :pray:

pors commented 2 years ago

Please, can we get this trivial PR merged? 🙏

@PabloCastellano I think it is not that trivial, see my comment above. These dependencies exist for a reason.

PabloCastellano commented 2 years ago

@pors That error is not related to this PR. If you clone master and do the same, you'll get incompatibilities too:

ERROR: graphql-relay 3.1.5 has requirement graphql-core<3.2,>=3.1, but you'll have graphql-core 2.3.2 which is incompatible.
ERROR: graphene 3.0 has requirement graphql-core~=3.1.2, but you'll have graphql-core 2.3.2 which is incompatible.
ERROR: graphene-django 2.15.0 has requirement graphene<3,>=2.1.7, but you'll have graphene 3.0 which is incompatible.
PabloCastellano commented 2 years ago

@pors check out my pr https://github.com/PedroBern/django-graphql-auth/pull/147 which supersedes this one