search

PedroBern / react-native-collapsible-tab-view

A cross-platform Collapsible Tab View component for React Native
MIT License
830 stars 161 forks source link

feat: SectionList support (without stickyHeaders for now) #201

Closed alexco2 closed 2 years ago

alexco2 commented 2 years ago

Added SectionList Support. Also updated documentation and added example tab with a SectionList. As we know from https://github.com/PedroBern/react-native-collapsible-tab-view/issues/136 stickyHeaders cause a problem. This issue also applies to SectionList. I played around with paddingTop, but couldn´t solve the issue. I also upgraded Expo to v42 and reanimated to v2.2.2.

alexco2 commented 2 years ago

I initially wanted to create a seperate pull request for the reanimated and Expo update, but it looks like I added the commit to this pull request. Sorry, I´m still a bit new to git. Anyway, this pr would close this issue: https://github.com/PedroBern/react-native-collapsible-tab-view/issues/164

PedroBern commented 2 years ago

hi @alexco2 thanks for the PR, appreciate the bump on expo and reanimated 🙌 But it has a bug (don't know if there are more bugs though, I stopped testing after this due to time constraints on my end):

https://user-images.githubusercontent.com/39778068/135697171-0e2758be-5ef3-4149-be7f-a14da398363d.mp4

alexco2 commented 2 years ago

Added SectionList Support. Also updated documentation and added example tab with a SectionList. As we know from https://github.com/PedroBern/react-native-collapsible-tab-view/issues/136 stickyHeaders cause a problem. This issue also applies to SectionList. I played around with paddingTop, but couldn´t solve the issue. I also upgraded Expo to v42 and reanimated to v2.2.2.

Hi @PedroBern Thank you for the quick reply. I've also noticed this bug. It's not a new one as it is the same one as in https://github.com/PedroBern/react-native-collapsible-tab-view/issues/136. I tried fixing it but wasn't successful. Should it be disabled by default on iOS?

PedroBern commented 2 years ago

@alexco2 with the required review changes looks good to me 🚀 thanks for the PR 🎉

@andreialecu could you please review as well?

andreialecu commented 2 years ago

I'll take a look tomorrow.

andreialecu commented 2 years ago

Released in 4.3.0 🚀

alexco2 commented 2 years ago

@PedroBern @andreialecu Amazing. This is my first PR 🎉. Thank you for merging and releasing so fast. Really motivates me to commit further to this library!

andreialecu commented 2 years ago

Thank you @alexco2, keep 'em coming! 💯