search

PedroBern / react-native-collapsible-tab-view

A cross-platform Collapsible Tab View component for React Native
MIT License
836 stars 162 forks source link

Fix ios behaviour (2) #67

Closed PedroBern closed 3 years ago

PedroBern commented 3 years ago

An alternative to #65.

@andreialecu, I didn't test it (I can't), but what you think?

Instead of using setTimeout, I handled everything on the UI, can you run the preview to see if it has the same behavior as your initial fix, please?

Also, having isGliding.value=true before isScrolling.value=false ensures we sync tabs after the snap, because of here.

Close #59

github-actions[bot] commented 3 years ago

The Expo app for the example from this branch is ready!

expo.io/@pedrobern/react-native-collapsible-tab-view-demos?release-channel=pr-67

alexpchin commented 3 years ago

@PedroBern I think this is cleaner than #65. It seems to work at my end.

andreialecu commented 3 years ago

I'm away for a bit so I can't test it right now. Seems you only rewrote the setTimeout part?

andreialecu commented 3 years ago

If @alexpchin confirms it works, feel free to merge this one instead of mine. We can revisit later if more fixes are needed.

alexpchin commented 3 years ago

@andreialecu Your changes have been incorporated too 👍 This PR is on top of the changes you made but re-writes the setTimeout and a couple of tidies.

PedroBern commented 3 years ago

rebased, just waiting for the preview for the record and will merge 🎉