search

PedroBern / react-native-collapsible-tab-view

A cross-platform Collapsible Tab View component for React Native
MIT License
836 stars 162 forks source link

Update documentation for `react-native-reanimated` and bump version in Example #73

Open alexpchin opened 3 years ago

alexpchin commented 3 years ago

react-native-reanimated v2 has quite a bit more set-up. It's not immediately clear that when installing the library, you have to be using v2 of the library.

Also, things like Direct Debugging are things that people who install v2 may not be expecting.

Also, we should bump the version in the example to 2.0.0-rc.2

PedroBern commented 3 years ago

I'm facing this issue when trying to bump the version https://github.com/software-mansion/react-native-reanimated/issues/1640

The workaround is to comment out the line responsible for the issue inside the node_modules. But wouldn't be able to deploy the preview from github actions. I would need to cancel all the actions and manually deploy, both for the main and for the PRs preview, which is really boring 🐤

alexpchin commented 3 years ago

@PedroBern I had to --reset-cache to make this go away I think?

PedroBern commented 3 years ago

I tried all kind of reset cache, including the metro bundler, but I still have the issue.

PedroBern commented 3 years ago

here is the explanation

andreialecu commented 3 years ago

I'm facing this issue when trying to bump the version software-mansion/react-native-reanimated#1640

While trying to test #58 in an actual app I've also ran into this. None of the reanimated2 rc versions worked (0, 1 or 2).

What did you do for a workaround @PedroBern? Commenting out the offending line is not something I can do in this project.

PedroBern commented 3 years ago

@andreialecu I did nothing, kept the rc.0. I faced this issue only with rc.1 and rc.2. Are you using expo? here are some useful commands to clean all the cache I tried (just updated to yarn) without success.

But you are not supposed to have this issue if not using expo.

andreialecu commented 3 years ago

I'm not using expo, on rc.0 I'm getting a different error instead though:

ReferenceError: Can't find variable: _globalSetter

Which seems to be reported here: https://github.com/software-mansion/react-native-reanimated/issues/1587

I cleared the caches using --reset-cache, without success.

andreialecu commented 3 years ago

Oh, nevermind. After adding the babel plugin it works now (on rc.0, didn't try the others): 

  plugins: ['react-native-reanimated/plugin'],
Draykee commented 3 years ago

I had this issue too and right now I'm pretty confused on what I should to.

You will be unable to use Remote JS Debugging if you use the new APIs from Reanimated 2 Expo (https://docs.expo.io/versions/latest/sdk/reanimated/)

It should be mentioned somewhere

UPDATE: SDK41 contains support for Reanimated 2