search

PedroBern / react-native-collapsible-tab-view

A cross-platform Collapsible Tab View component for React Native
MIT License
834 stars 162 forks source link

feat: add support for collpased header height #85

Closed tcorreiaubi closed 3 years ago

tcorreiaubi commented 3 years ago

Hey @PedroBern, this allows to configure a height for the header when collapsed, in other words, the header will be considered collapsed once we reach, header height - collapsed height, I tested all the examples and they seem to be working properly, so I believe I got all the right variables in their place, but if you can give a new look, since you know the project/behavior better than me

Closes #5

tcorreiaubi commented 3 years ago

@PedroBern Related to the snapThreshold, do you think it should be applied to the headerHeight or the headerScrollDistance(headerHeight - minHeaderHeight)? at the moment it's applied to the headerScrollDistance

PedroBern commented 3 years ago

@PedroBern Related to the snapThreshold, do you think it should be applied to the headerHeight or the headerScrollDistance(headerHeight - minHeaderHeight)? at the moment it's applied to the headerScrollDistance

headerScrollDistance is correct 👍