search

PedroBern / react-native-collapsible-tab-view

A cross-platform Collapsible Tab View component for React Native
MIT License
834 stars 162 forks source link

Support for Sectionlist #97

Closed alexco2 closed 2 years ago

alexco2 commented 3 years ago

Hello, first of all, amazing package. This is something the rn community definetly needs! One question though. Do you plan to support Sectionlist, or is there a way to make it work with sectionlist?

andreialecu commented 3 years ago

The refactoring made as part of #93 should make this very easy to add.

andreialecu commented 3 years ago

This will actually not be easily possible to do on iOS because of issues described in this comment: https://github.com/PedroBern/react-native-collapsible-tab-view/issues/136#issuecomment-780606731

RoscoeZhao commented 3 years ago

Hi @andreialecu , firstly I want to say thank you for this great component! The PR which fixs the iOS offset issue, https://github.com/facebook/react-native/pull/30737 , has been merged to RN. Would you please add support for SectionList ? Thank you very much!

andreialecu commented 3 years ago

@RoscoeZhao unfortunately even though the PR was merged, RN0.64 does not include it.

You can verify by comparing https://cdn.jsdelivr.net/npm/react-native@0.64.0/React/Views/RefreshControl/RCTRefreshControl.m with the changes in the PR.

The release workflow of RN diverges from what is in master. Instead, they cherry pick commits: https://github.com/react-native-community/releases/issues/221

RN 0.64.1 is not scheduled to have it either, as per the thread linked above.

alexco2 commented 3 years ago

I asked for a cherrypick. If you give the comment some attention, perhaps It'll work ;)

davidbiedenbach commented 2 years ago

I guess 30737 finally made it into 0.65 =)

alexco2 commented 2 years ago

@andreialecu since the PR is now included in RN 0.65, is there a plan to support sectionlist as well? :)

andreialecu commented 2 years ago

Sure, we can consider a PR that adds section list support if anyone is willing to implement it. 🙂

alexco2 commented 2 years ago

Are there some considerations that come into your mind regarding the implementation of SectionList? @andreialecu

alexco2 commented 2 years ago

@andreialecu I was able to make SectionList work. I will test it further and commit a PR if everything works fine. Also, I will look into bumping reanimated to version 2.2.2 for an additional PR. https://github.com/PedroBern/react-native-collapsible-tab-view/issues/164

alexco2 commented 2 years ago

I commited the PR. Please let me know if anything is missing. Would be happy if the feature could be merged and shipped :) https://github.com/PedroBern/react-native-collapsible-tab-view/pull/201