search

PeeHaa / OpCacheGUI

GUI for PHP's OpCache
1.46k stars 170 forks source link

Login auth doesn't work #44

Closed soullivaneuh closed 9 years ago

soullivaneuh commented 9 years ago

Login doesn't work.

I think is caused by these line: https://github.com/PeeHaa/OpCacheGUI/blob/master/src/OpCacheGUI/Auth/User.php#L93-L95

Why return immediatly false? If my IP is not white-listed, the auth check will be never processed isn't it?

PeeHaa commented 9 years ago

Hi,

what do you mean. Unless I am misunderstanding you what is happening it the expected result?

As in: if you ip address is not whitelisted it should never process the credentials because access is denied either way.

If my IP is not white-listed, the auth check will be never processed isn't it?

Yes correct, which is by design.

If you think there is an error/bug somewhere I need some more information besides the fact that login doesn't work.

What does your config look like (the username / password / whitelist part)?

soullivaneuh commented 9 years ago

Ok I misunderstand the app design. I was thinking that if ip not authorized, then process password auth.

Thanks.