search

Peekmo / atom-autocomplete-php

Autocomplete for PHP in atom editor
MIT License
136 stars 34 forks source link

Fix autocompletion for namespace with leading lowercase character - fixes #250 #252

Closed iluuu1994 closed 8 years ago

iluuu1994 commented 8 years ago

As described in #250, the package is not able to autocomplete local variables where the first character of the namespace is a lowercase character. E.g.:

$bar = new \foo\Bar;

This pull request fixes that issue.

Peekmo commented 8 years ago

Thank you,

It was intentional (to avoid code execution), but, even if according to PSR norms it's not authorized, sometimes it begins by a lowercase letter.. so.. ok.^^

iluuu1994 commented 8 years ago

Oh, I see. You're obviously right. So our company just doesn't like standards 😂👍

On 09 May 2016, at 13:52, Axel Anceau notifications@github.com wrote:

Thank you,

It was intentional (to avoid code execution), but, even if according to PSR norms it's not authorized, sometimes it begins by a lowercase letter.. so.. ok.^^

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub