Overrides redo keybinding in atom

Peekmo / atom-autocomplete-php

Autocomplete for PHP in atom editor

MIT License

136 stars 34 forks source link

Overrides redo keybinding in atom #268

Closed benkaiser closed 8 years ago

benkaiser commented 8 years ago

Is there a reason this is done?

https://github.com/Peekmo/atom-autocomplete-php/blob/2b054edc166a253e61de049555aa36623864f58a/keymaps/atom-autocomplete-php.cson#L4

I just use this package for better autocompletion, didn't expect it to override major keybindings...

Peekmo commented 8 years ago

Hello,

No major reason, there's a lot of keybindings in atom, just unluck that it overrides this one. You can remove/change it in your configuration.

Regards, Peekmo

benkaiser commented 8 years ago

Hi Peekmo,

Thanks for your reply,

That is true that there are lots of keybindings in atom, but this a keybinding that is pretty fundamental to any text-editor. I understand it can be overridden in a users configuration but making extra work for users to restore very standard editor keybindings really doesn't seem that user-friendly.

Cheers, Ben

vip9 commented 8 years ago

+1 to change it. It took me a lot of time to search what overrides redo.