search

Peekmo / atom-autocomplete-php

Autocomplete for PHP in atom editor
MIT License
136 stars 34 forks source link

Core functions tooltips + go to docs #346

Closed Josh-G closed 7 years ago

Josh-G commented 7 years ago

This shows tooltips for php core functions and allows clicking through to the php docs page. Previously, the behaviour for me was opening an undefined page on click.

Peekmo commented 7 years ago

Hi,

Nice feature, but I have a question, it is just supposed to open the PHP doc into a new window ? It's not supposed to print the doc on hover ? (your PR title is a bit confusing to me)

Josh-G commented 7 years ago

Apologies. The tooltip now shows for core functions, however only the argument list is correctly populated. The 'go-to' click now opens the relevant php.net function page in the users browser. Here is a gif of how it functions now: https://gyazo.com/d2dbf36a4827da6aef76c8be1d82d4bc

Previous behaviour was no tooltip for core functions and go-to click would open an 'undefined' tab in Atom (atleast for me).