search

PeepDB-dev / peepdb

CLI tool and python library to inspect databases fast.
https://peepdb.dev/
GNU General Public License v3.0
59 stars 6 forks source link

Support for Additional Databases (e.g., SQLite, Oracle, SQL Server) #24

Open evangelosmeklis opened 6 days ago

evangelosmeklis commented 6 days ago

This should be added to release 0.1.4 (after 0.1.3 is released)

ArthureVarghese commented 6 days ago

I think it will be better to split logics of each db separately. This could help when adding more features and also when adding additional databases.

evangelosmeklis commented 5 days ago

@ArthureVarghese Hey thanks for the suggestion. This is a good idea. Probably creating a file for each database which will then be called by the core.py ex: mysql.py, postgres.py, mariadb.py. I am planning to make a new release tomorrow or monday, then we can restructure. If you want to try feel free, otherwise I will do it

ArthureVarghese commented 5 days ago

Yeah sure. I'll try. Thank You

ArthureVarghese commented 4 days ago

@evangelosmeklis Should I do this after next release or start from now?

evangelosmeklis commented 4 days ago

@ArthureVarghese Just start now if you want. I will do the release and you can pull the changes and fix any conflicts. I think there will not be many.

ArthureVarghese commented 3 days ago

@evangelosmeklis I have a basic version of the changes. Should i submit a PR? I have some more ideas/suggestions to improve them.

evangelosmeklis commented 3 days ago

@ArthureVarghese yes please do submit it! Make sure you run the unittests before making the pr and also if you have added new stuff create a unittest for them. For new features discussion please open an issue with label feature 😁