search

Peer5 / videojs-contrib-hls.js

HLS library for video.js using Dailymotion's hls.js tech
Apache License 2.0
108 stars 55 forks source link

Fix caption integration #19

Closed willkelleher closed 7 years ago

willkelleher commented 7 years ago

This may be a little hacky, but it does fix in-band caption integration on versions of video.js > 5.13.0.

Related to https://github.com/Peer5/videojs-contrib-hls.js/issues/17

ranuser99 commented 7 years ago

There are several drawing/display issues with live streams. It's very hard to visually follow.

Here's an example captioned live stream:

https://1-fss-fso35.streamhoster.com/lv_ntv/broadcast1/playlist.m3u8

The hls.js demo displays this perfectly (new lines on bottom and grow as new text arrives, pushing old content up):

http://streambox.fr/mse/hls.js-0.7.6/demo/

Is hls.js leveraging native caption drawing in the browser? How can videojs take advantage of native caption functionality when available?

tmm1 commented 7 years ago

@ranuser99 Did you try reverting https://github.com/videojs/video.js/pull/3798, as it seems the problems started after that commit

ranuser99 commented 7 years ago

The issue is apparently solved using older videojs 5.13.2 (from another user's suggestion).

mrbar42 commented 7 years ago

superseded by #25 thanks for the PR