search

Peer5 / videojs-contrib-hls.js

HLS library for video.js using Dailymotion's hls.js tech
Apache License 2.0
108 stars 55 forks source link

README is misleading #2

Closed jgubman closed 8 years ago

jgubman commented 8 years ago

According to your README, this plugin replaces the official videojs/videojs-contrib-hls According to them, that's not true: https://github.com/videojs/videojs-contrib-hls/issues/797

gkatsev commented 8 years ago

Heh, thanks. I just wrote #3 as well :D

jgubman commented 8 years ago

👍

gkatsev commented 8 years ago

Quoting what I said in #3 below:

The README here says that it is replacing videojs-contrib-hls. But it is not replacing it. videojs-contrib-hls is still a live project that is being active worked on. It would be nice if instead it just calls out that it is similar to videojs-contrib-hls.

shacharz commented 8 years ago

Sorry for the confusion, I tried to pass to the reader the notion that he doesn't need both on his page. He can replace the existing contrib-hls on his page if he wishes to. Willing to accept PRs / suggestions

jgubman commented 8 years ago

PR submitted

jgubman commented 8 years ago

Thanks!

shacharz commented 8 years ago

Thank you ;)