search

Peer5 / videojs-contrib-hls.js

HLS library for video.js using Dailymotion's hls.js tech
Apache License 2.0
108 stars 55 forks source link

Does not support videojs-contrib-quality-levels #38

Open stevendesu opened 5 years ago

stevendesu commented 5 years ago

I just made the switch from @videojs/http-streaming to videojs-contrib-hls.js to try and fix playback of several different videos that were not working properly in @videojs/http-streaming. However my player has a quality selector button which displays the various renditions available (1080p, 720p, 540p, etc) - and his button stopped functioning with HLS.js

If HLS.js provides events for the detection of new renditions or hooks for determining which rendition is currently playing or limiting which renditions are allowed, then adding support for videojs-contrib-quality-levels shouldn't be impossible. If HLS.js does not provide this and instead black-boxes all of the playback details, then a pull request on HLS.js may be necessary.

mbc-audiovisuales commented 3 years ago

Checked with Novage p2p-media-loader-hlsjs demo.

Adding videojs-hls-quality-selector dependency breaks p2p-media-loader P2P nature, letting quality selector to come to scene.

Seems not compat