search

PeerAssets / chizukeki

チズケキ PeerAssets-able Peercoin web wallet.
https://peerassets.github.io/chizukeki/
BSD 3-Clause "New" or "Revised" License
3 stars 6 forks source link

Conflicting information about tx confirmations #46

Open peerchemist opened 6 years ago

peerchemist commented 6 years ago

In the Assets tab, the following transaction shows "pending". screenshot from 2018-07-21 17-10-30

The same transaction in the Wallet tab shows 11 confirmations: screenshot from 2018-07-21 17-11-21

micimize commented 6 years ago

This is partially because the CardTransfer hasn't been seen by papi.

It is certainly confusing though - We could connect confirmed transactions with pending transfers, and add a status: pending field, but it's still kinda confusing to the user. I don't think we should just mark them confirmed, because they might be invalid.

peerchemist commented 6 years ago

tx 0f464ae667172f15a60e2a630d78e9de6ef0d5460ac5b430a8ad92e0d3b590d0 is visible in papi: https://papi.peercoin.net/api/v1/decks/adc6d888508ebfcad5c182df4ae94553bae6287735d76b8d64b3de8d29fc2b5b

and still shown as "pending" by chizukeki.

micimize commented 6 years ago

That could be because it's invalid, which we don't sync right now. There are questions as to how that UX should look - I think the best thing to do is maybe add a marker and an ❌ so the user can delete it.

But as for this issue specifically, I'm not going to be able to debug this kind of stuff until papi consistently registers CardTransfers again.

peerchemist commented 6 years ago

I think the best thing to do is maybe add a marker and an x so the user can delete it.

yes, this is good idea.