PeerAssets / pypeerassets

Reference implementation of the PeerAssets protocol.
BSD 3-Clause "New" or "Revised" License
12 stars 16 forks source link

WIP - Check integration with new btcpy #121

Closed belovachap closed 6 years ago

belovachap commented 6 years ago

@peerchemist @saeveritt

We don't have to merge this, just wanted to make sure the newest btcpy changes didn't break anything. All the tests pass and a few more resolved :)

Not sure what other plans you had for testing btcpy, but at least it works for this one case :fireworks:

saeveritt commented 6 years ago

Everything looks good. The only thing I see is that the wif property needs to be modified. to_wif() as per the new btcpy should take the network as an input arg.


    @property
    def wif(self) -> str:
        '''convert raw private key to WIF'''

        btcpy_constants = net_query(self.network).btcpy_constants
        return self._private_key.to_wif(btcpy_constants)
peerchemist commented 6 years ago

@belovachap can you push the new branch with this code? I'd leave it in testing for a while it's a big change.