search

PeerAssets / pypeerassets

Reference implementation of the PeerAssets protocol.
BSD 3-Clause "New" or "Revised" License
12 stars 16 forks source link

correct holytransaction's network aliasing methods #68

Closed micimize closed 7 years ago

micimize commented 7 years ago

Holy.network_short_to_long and Holy.network_long_to_short had reversed len checks

micimize commented 7 years ago

@saeveritt made the changes, although in network_long_to_short, len('tppc') > 3, so it will be checked. Though really, these len checks seem a bit unneeded anyways

peerchemist commented 7 years ago

I want to extract this network name logic into common.py placed in provider submodule as other providers also need similar or same functionality.

peerchemist commented 7 years ago

I'll rework this code in provider/*

peerchemist commented 7 years ago

Fixed with https://github.com/PeerAssets/pypeerassets/commit/26480b7cf66f9c0af99be9d442667381db651f2c