search

PeerDB-io / peerdb

Fast, Simple and a cost effective tool to replicate data from Postgres to Data Warehouses, Queues and Storage
https://peerdb.io
Other
1.91k stars 60 forks source link

don't call getMaxSyncsPerCDCFlow in loop #1859

Closed serprex closed 1 week ago

serprex commented 1 week ago

this was spamming temporal history

heavycrystal commented 1 week ago

defeats the purpose of it being dynconf

serprex commented 1 week ago

it doesn't, dynconf has ui, pause/unpause takes on change. Soft pause should be implemented separately

serprex commented 1 week ago

alternatively, use https://pkg.go.dev/go.temporal.io/sdk/workflow#MutableSideEffect

serprex commented 1 week ago

prodding more, MutableSideEffect is taking workflow.Context & passing down workflow.Context, creating context.Context with deadline which is scoped by calling context.Context isn't straightforward