search

PeerDB-io / peerdb

Fast, Simple and a cost effective tool to replicate data from Postgres to Data Warehouses, Queues and Storage
https://peerdb.io
Other
2.25k stars 92 forks source link

Package generated protos for a CH service to call #1992

Closed pjhampton closed 3 months ago

pjhampton commented 3 months ago

Summary

This makes the protos available to a ClickHouse service that needs them to talk to the flow-api.

For now, I suggest we release this manually via

git tag flow/flow-api-client/v0.1.0
git push origin flow/flow-api-client/v0.1.0

and retrieve it in the internal codebase with

go get github.com/PeerDB-io/peerdb/flow/flow-api-client@v1.0.0

Future work

I was planning to add a Github action to release this automatically, but this requires state management to maintain the version + bump, and I want to see if this is still the approach we adopt in a couple of weeks when we have everything working e2e.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

serprex commented 3 months ago

this shows how go's repo-as-module breaks down unless you move this to some go build step. If repo must have build artifacts then there should instead be a github action on commit to main that pushes these generated files to a different repository which is entirely code generated

pjhampton commented 3 months ago

this shows how go's repo-as-module breaks down unless you move this to some go build step. If repo must have build artifacts then there should instead be a github action on commit to main that pushes these generated files to a different repository which is entirely code generated

I agree. Let's do that once we have stabilised the provisioning in the ingest platform api