PeerHerholz / bids_bep16_conv

A small package to implement conversions between BEP-16 (Diffusion Derivatives) compliant datasets and other/existing software outputs.
https://peerherholz.github.io/bids_bep16_conv
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

FSL ball-and-sticks output #13

Open Lestropie opened 5 months ago

Lestropie commented 5 months ago

Invested a fair bit of effort in building ball-and-sticks compatibility into the spec and verifying its orientation encoding: https://github.com/Lestropie/DWI_metadata. So would like to get support for that into the tool.

PeerHerholz commented 5 months ago

Hi @Lestropie,

thanks for this! After a quick look, I'm not quite sure re the implementation. The App so far takes preprocessed dwi data as input and thus we would have to add a few workflows to incorporate your work, specifically, the orientation encoding validation and then ball-and-sticks compatibility, correct?

Thanks again.

Best, Peer

Lestropie commented 5 months ago

You don't need to do any validation of orientation encoding here. The purpose of the linked project was to provide adequate guarantees here that if we do the trivial manipulations above, then slap:

{
    "OrientationEncoding": {
        "Reference": "bvec",
        "Type": "spherical"
    }
}

in the sidecar (acknowledging potential change in https://github.com/bids-standard/bids-bep016/issues/106), then there is no error or ambiguity about how stored image intensities relate to estimated fibre orientations. One way that we will be able to prove that such interpretation is correct is by converting fibre orientations estimated by one software into the format expected by the other software, and showing visually that they make anatomical sense. But at least for now I would consider that out of scope for this specific piece of software; focus here should be on just fitting a model and then encoding its outputs.