Pegase745 / sqlalchemy-datatables

SQLAlchemy integration of jQuery DataTables >= 1.10.x (Pyramid and Flask examples)
MIT License
159 stars 67 forks source link

Avoid duplicates in select menus (with yadcf) #102

Open pankus opened 7 years ago

pankus commented 7 years ago

... this small piece of code works quite well for my needs, but I can't figure it out whitin different situation

codecov[bot] commented 7 years ago

Codecov Report

Merging #102 into master will decrease coverage by 0.45%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   93.68%   93.22%   -0.46%     
==========================================
  Files           1        1              
  Lines         190      192       +2     
==========================================
+ Hits          178      179       +1     
- Misses         12       13       +1
Impacted Files Coverage Δ
datatables/__init__.py 93.22% <50%> (-0.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1e686a...6912cb2. Read the comment docs.

tdamsma commented 7 years ago

This seems like a good change, but there is no test coverage for this. @pankus , do you feel comfortable adding a test that reproduces the desired behaviour? I don't have time right now to look into this, but will do eventually

pankus commented 7 years ago

I can try, even if I don't know where to start !!