Pegase745 / sqlalchemy-datatables

SQLAlchemy integration of jQuery DataTables >= 1.10.x (Pyramid and Flask examples)
MIT License
159 stars 67 forks source link

Individual column search option #21

Closed ashl1 closed 9 years ago

ashl1 commented 9 years ago

Could you explainn the search_like option for columns? As writed in datatables.py:47 the type of this argument is string, but in code (datatables.py:213) it is only checked for boolean. Is the argument 'search_like' really boolean type? Or may code haven't yet completed with that feature?

Pegase745 commented 9 years ago

True to that, thanks for the heads up. I guess there's something missing, because the search_like is not used anywhere. I'll see into that when I have time, or don't hesitate to PR

ashl1 commented 9 years ago

As I understand the 'search_like' should be like used in datatables.py:213. It can usefull if you want to add something to the standart LIKE behavior and don't think this is required. Three solutions are possible:

I suggest the first solution before the real use case will become. What do you think about?

Pegase745 commented 9 years ago

Yes, the first solution is ok by me for now too

Pegase745 commented 9 years ago

Nevertheless please keep in mind that the library will change in 0.2.0 because of its refactoring for it to include unit tests and DT 1.10.x compatibility

ashl1 commented 9 years ago

Do you have any code changes now? Because I'm almost finished basic support DT 1.10.x (only transocding arguments, not implement all features). If you has, could you publish the branch to git to use or fork it?

Pegase745 commented 9 years ago

For the DT 1.10, i'll make a new branch. Please do the PR on it in order to be clean ;-)