allow filter based on row data

Pegase745 / sqlalchemy-datatables

SQLAlchemy integration of jQuery DataTables >= 1.10.x (Pyramid and Flask examples)

MIT License

159 stars 67 forks source link

allow filter based on row data #39

Closed louking closed 8 years ago

louking commented 8 years ago

new parameter filterarg
filterarg = 'cell' is default with filter=f(cell) as in 0.2.1
filterarg = 'row' allows filter=f(row) for more complex filtering
fixes https://github.com/Pegase745/sqlalchemy-datatables/issues/38

Pegase745 commented 8 years ago

still a difference with #41 ? or you created a new PR from this branch ?

louking commented 8 years ago

I created #41 from this branch. This feature can be taken separately. Note I did not look at unit tests when I built this.

Pegase745 commented 8 years ago

yep same problem with format I guess ;)

Pegase745 commented 8 years ago

rebase onto master, as I added a quickfix earlier. And if you want I can merge this one, and let you enhance #41 . that's ok with you?

louking commented 8 years ago

are you asking me to rebase before you take this one?

yes you can wait on #41 until I improve it

louking commented 8 years ago

should be ready for you now

Pegase745 commented 8 years ago

merged it. thanks.

when you have time, could you possibly unit test fitlerarg before we pass onto the regex problems ? :)

louking commented 8 years ago

will try to do today. now I have travis installed on my fork. thanks for allowing me to use sqlalchemy-datatables as my tutorial repo ;)

Pegase745 commented 8 years ago

No worries !

On Thu, Mar 10, 2016 at 12:09 PM, Lou King notifications@github.com wrote:

will try to do today. now I have travis installed on my fork. thanks for allowing me to use sqlalchemy-datatables as my tutorial repo ;)

— Reply to this email directly or view it on GitHub https://github.com/Pegase745/sqlalchemy-datatables/pull/39#issuecomment-194794072 .