search

Pegase745 / sqlalchemy-datatables

SQLAlchemy integration of jQuery DataTables >= 1.10.x (Pyramid and Flask examples)
MIT License
159 stars 67 forks source link

patch for sql order_by query #50

Closed mh00h closed 7 years ago

mh00h commented 8 years ago

Using PSQL and a table name like Tables1 (note the capital T), the sql query will fail if the ORDER_BY table specified is not enclosed in quotes. This is a patch to ensure that said table will be quoted.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 87.156% when pulling 45f9ca870525e310cb668577ad3c19b32e1cb6c7 on mh00h:master into 096ace624a3ca68f2d4aad6721547777ed38a98e on Pegase745:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 87.156% when pulling 3c04d01068f55bf298e16b57b489a3cc7660e497 on mh00h:master into 096ace624a3ca68f2d4aad6721547777ed38a98e on Pegase745:master.

mh00h commented 8 years ago

@Pegase745 What else do we need to do to work on this issue?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 87.156% when pulling 5f6d74246f597e32b620ffe47767891a3b5e5374 on mh00h:master into 096ace624a3ca68f2d4aad6721547777ed38a98e on Pegase745:master.

tdamsma commented 7 years ago

I am closing the PR as this should be covered in >1.0.0