search

Pegase745 / sqlalchemy-datatables

SQLAlchemy integration of jQuery DataTables >= 1.10.x (Pyramid and Flask examples)
MIT License
159 stars 67 forks source link

Allow yadcf range #58 #63

Closed louking closed 7 years ago

louking commented 8 years ago

This allows https://github.com/vedmack/yadcf to send range of dates or numbers to be retrieved properly. yadcf assumes a particular delimiter string which is sent between the range values, but this could easily be modified to allow configuration of another delimiter.

This also allows paging to be set to false. The commit which allows paging to be set to false 83091d0654f428624e6aa9493e2a8d4c356c5bff seems to have broken the build for python 2.6, but it is not clear to me how that broke.

I had been planning to do the unit tests for the new range feature, but ran out of time as I was building the application which uses this. After so much time has elapsed, I thought I would pass this on as it stands.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-10.09%) to 77.068% when pulling 0b92cc8439c246699ba779184a08f875c852eade on louking:allow-yadcf-range-#58 into 096ace624a3ca68f2d4aad6721547777ed38a98e on Pegase745:master.

louking commented 8 years ago

Sorry (it's been so long). It was https://github.com/Pegase745/sqlalchemy-datatables/pull/63/commits/de90a7a04323fa55beb088b5716572040b401fe7 whic broke the build for python 2.6. Still I am not clear how I broke this.

tdamsma commented 7 years ago

I am closing the PR as this should be covered in >1.0.0