search

Pegase745 / sqlalchemy-datatables

SQLAlchemy integration of jQuery DataTables >= 1.10.x (Pyramid and Flask examples)
MIT License
159 stars 67 forks source link

Update Flask example #75

Closed grakic closed 7 years ago

grakic commented 7 years ago

Resolves issue #70

codecov-io commented 7 years ago

Current coverage is 95.00% (diff: 100%)

Merging #75 into master will not change coverage

@@             master        #75   diff @@
==========================================
  Files             6          6          
  Lines           621        621          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            590        590          
  Misses           31         31          
  Partials          0          0

Powered by Codecov. Last update ac80ddf...d6faa16

tdamsma commented 7 years ago

Great work, do you think it would be worth it to also expand the flask example for to cover all cases the pyramid example does?

Pegase745 commented 7 years ago

Great work indeed, thanks !

tdamsma commented 7 years ago

Also solves https://github.com/Pegase745/sqlalchemy-datatables/issues/74

grakic commented 7 years ago

@tdamsma It would be great, but I do not have time for it now

Pegase745 commented 7 years ago

let's merge that as it is, and will update that in a next iteration

Pegase745 commented 7 years ago

Closes #70