moved all modifications of database to setUp and tearDown functions

Pegase745 / sqlalchemy-datatables

SQLAlchemy integration of jQuery DataTables >= 1.10.x (Pyramid and Flask examples)

MIT License

159 stars 67 forks source link

Closed tdamsma closed 7 years ago

Pegase745 commented 7 years ago

@tdamsma yep I thought of it afterwards. You were faster :)

tdamsma commented 7 years ago

anyways, it doesn't solve the main issue, cause 2/3 tests are failing with no reason. Could you try a rebuild?

tdamsma commented 7 years ago

Ideas for work around:

place sqlite db on disk instead of in memory, and properly delete it.
use a proper db backend (postgres of mysql), with added benefit of being able to actually test
- nulls ordering
- regex searching

Pegase745 commented 7 years ago

i'll setup the postgres yeah

codecov-io commented 7 years ago

No coverage report found for fix-tests at 54c2efe.

Powered by Codecov. Last update 54c2efe...07ccd11

Pegase745 commented 7 years ago

@tdamsma tell me when it's ok to merge in my branch

tdamsma commented 7 years ago

@Pegase745 I think that (except for db errors) the tests should be ok now. So now would be ok