PeggyJV / il-loss-charts

🍷 The Finest Liquidity Management tools for LPs.
https://app.sommelier.finance/
Apache License 2.0
6 stars 14 forks source link

UX: As a user, I want to be able to withdraw my liquidity #55

Open kkennis opened 3 years ago

kkennis commented 3 years ago

This is a companion task to #52 - the 'remove liquidity' converse to 'add liquidity'. Users should be able to fully manage their liquidity lifecycle on Sommelier, which includes the removal step.

This will be much simpler than add liquidity - as an MVP, they should only be able to remove 100% of their liquidity, in essence, burn their NFLP.

Updating their position atomically is out of scope. Users can update their positions by removing liquidity and adding liquidity separately, which are flows we will already support.

The user needs a flow where they can: 1) Select a pool from their open positions 2) Choose to remove the liquidity 3) Confirm the details of their action and submit their transaction

This task should also cover the needed contract interactions and approvals, if needed.

Acceptance Criteria:

kkennis commented 3 years ago

Launch day thought: maybe we have a Remove button, but it's just a deep-link to remove on the Uniswap V3 app? That way we don't need to build anything special, and there is no 'simplifying the experience' we are doing for remove anyway.