Closed henrio123 closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
sommelier-web | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 18, 2024 9:59am |
[!WARNING]
Review failed
The pull request is closed.
The overall change in src/data/uiConfig.ts
revolves around adjustments to functions managing APY labels and chart labels based on the cellarNameKey
values. Specifically, the key REAL_YIELD_ETH_OPT
has been targeted—being added or removed from various conditions within these functions to refine the logic and display associated with different cellar configurations.
File | Change Summary |
---|---|
src/data/uiConfig.ts |
- Added REAL_YIELD_ETH_OPT condition to isApyChartEnabled |
- Removed REAL_YIELD_ETH_ARB , REAL_YIELD_USD_ARB , and REAL_YIELD_ETH_OPT from apyLabel and apyChartLabel |
|
- Removed REAL_YIELD_ETH_OPT from apyHoverLabel , baseApyHoverLabel , and isEstimatedApyEnable |
|
- Commented out the block related to REAL_YIELD_ETH_OPT in estimatedApyValue |
"Amidst the code, where options yield,
REAL_YIELD_ETH_OPT
has a new field. With keys adjusted, labels shift, APYs now bear a different gift. Charts in harmony, logic pure, The UI sings of updates, sure! 🐇✨"
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Fixes #
Description
Describe big picture changes here. This will give viewers context for the changes.
Changes
List any technical changes.
Screenshots (if appropriate):
Testing Steps
As a reviewer, what steps should I take to verify this is working correctly?
Links
Add links to Figma files, documentation, etc.
Summary by CodeRabbit
REAL_YIELD_ETH_OPT
to ensure accurate display of APY information.