search

PeggyJV / sommelier-strangelove

https://sommelier.strangelove.ventures/
5 stars 3 forks source link

Fix merkle apy calc #1701

Closed otsalex closed 5 days ago

otsalex commented 5 days ago

ARB tokens in period ->30000 for REAL_YIELD_ETH_ARB and 7500 for REAL_YIELD_USD_ARB.

Replaced stakerContract.totalDeposits() call to cellarContract.totalAssets()

Summary by CodeRabbit

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sommelier-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 6:00pm
coderabbitai[bot] commented 5 days ago

Walkthrough

The recent updates focus on refining the calculation of APY for merkle rewards by differentiating between ETH and USD values based on the cellar name key. Additionally, function parameters have been renamed and adjusted to reflect this new logic. These modifications aim to enhance accuracy in reward calculations and streamline the function interactions.

Changes

Files/Paths Change Summaries
src/data/actions/common/getMerkleRewardsApy.ts Updated calculations to distinguish between ETH and USD, renamed constants, and adjusted function parameters and calls accordingly.
src/data/actions/common/getStrategyData.ts Altered the function to pass cellarContract instead of stakerContract to getMerkleRewardsApy based on strategy slugs.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant StrategyDataFunction
    participant MerkleRewardsFunction
    participant CellarContract

    User->>StrategyDataFunction: Call getStrategyData()
    StrategyDataFunction->>MerkleRewardsFunction: Call getMerkleRewardsApy(cellarContract)
    MerkleRewardsFunction->>CellarContract: Call fetchTotalValueStaked()
    CellarContract->>MerkleRewardsFunction: Return totalAssets
    MerkleRewardsFunction->>MerkleRewardsFunction: Calculate APY
    MerkleRewardsFunction->>StrategyDataFunction: Return APY
    StrategyDataFunction->>User: Return strategy data with APY

Poem

In the basement of code where changes bloom,
APY calculations sing a new tune.
With ETH and USD now separate in flight,
Cellars whisper softly in the quiet night.
Contracts and strategies find their way,
Rewards more precise at the break of day.
🎉✨

[!TIP]

AI model upgrade ## `gpt-4o` model for reviews and chat is now live OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide any feedback or to report any issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.