search

PeggyJV / steward

Eth Contract Monitor
Apache License 2.0
31 stars 18 forks source link

Add Aave V3 Debt Token adaptors to flashloan list for aave v3 #260

Closed cbrit closed 6 months ago

cbrit commented 6 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The recent updates primarily focus on enhancing the functionality of the Aave V3 debt token system. Changes include a modification in the hash_proto file affecting hash values, an addition of an import and a new message field in the aave_v3_debt_token_flash_loan.proto, and an extension in the aave_v3.rs to support new adaptor calls. These modifications enhance interoperability and extend the capabilities of the existing systems.

Changes

File Path Change Summary
hash_proto Functionality change affecting hash values.
proto/steward/v4/.../aave_v3_debt_token_flash_loan.proto Added import and new message field to support Aave V3 debt token.
src/cellars/adaptors/aave_v3.rs Extended get_encoded_adaptor_calls function to include new case for Aave V3 debt token adaptor calls.
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 3ba15c35d85a6ca0d294a168b5799ec124ce8b42 and 89e2f18804c72324f24a271faf746240d0e68a46.
Files ignored due to path filters (4) * `Cargo.lock` is excluded by `!**/*.lock`, `!**/*.lock` * `Cargo.toml` is excluded by `!**/*.toml` * `crates/steward-proto/src/gen/descriptor.bin` is excluded by `!**/*.bin`, `!**/*.bin`, `!**/gen/**` * `crates/steward-proto/src/gen/steward.v4.rs` is excluded by `!**/gen/**`
Files selected for processing (3) * hash_proto (1 hunks) * proto/steward/v4/aave_v3_debt_token_flash_loan.proto (2 hunks) * src/cellars/adaptors/aave_v3.rs (1 hunks)
Files not reviewed due to errors (1) * proto/steward/v4/aave_v3_debt_token_flash_loan.proto (no review received)
Files skipped from review due to trivial changes (1) * hash_proto
Additional comments not posted (1)
src/cellars/adaptors/aave_v3.rs (1)
`300-302`: New case addition for handling Aave V3 Debt Token Adaptor V1 calls is correctly implemented and placed within the match statement of the `get_encoded_adaptor_calls` function.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.