search

PeggyJV / steward

Eth Contract Monitor
Apache License 2.0
31 stars 18 forks source link

New oracle permissions #271

Closed zmanian closed 3 months ago

zmanian commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes enhance the price oracle management system by introducing new oracles for TurboSteth and TurboGHO, expanding the allowed price oracles, and improving the validation function. These updates enable the inclusion of additional oracles and strengthen the robustness of the oracle validation process, thereby broadening the system's overall functionality.

Changes

Files Change Summary
src/cellars.rs Introduced constants for TURBOSTETH_ORACLE1 and TURBOGHO_ORACLE1 along with their allowed oracles. Updated ALLOWED_TURBOSWETH_PRICE_ORACLES to six entries and expanded ALLOWED_V2_5_CATALOGUE_POSITIONS to eight entries. Modified validate_oracle to incorporate new checks for TurboSteth and TurboGHO.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Validator
    participant PriceOracle

    User->>Validator: Request oracle validation
    Validator->>PriceOracle: Check if oracle is allowed
    PriceOracle-->>Validator: Return validation result
    Validator-->>User: Provide validation response
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 7e3c3c92dd8f7165e57ace3434830a5d942ff979 and 0609f371f53f5498d5d3fe6bdc3dfaa4effb0e8a.
Files selected for processing (1) * src/cellars.rs (5 hunks)
Additional comments not posted (4)
src/cellars.rs (4)
`27-31`: **LGTM!** The new constants `TURBOSTETH_ORACLE1` and `ALLOWED_TURBOSTETH_PRICE_ORACLES` are correctly defined with lowercase addresses. --- `34-39`: **LGTM!** The new constants `TURBOGHO_ORACLE1` and `ALLOWED_TURBOGHO_PRICE_ORACLES` are correctly defined with lowercase addresses. --- `64-75`: **LGTM!** The new constant `TURBOSWETH_ORACLE6` is correctly added to the `ALLOWED_TURBOSWETH_PRICE_ORACLES` array with a lowercase address. --- `170-178`: **LGTM!** The `ALLOWED_V2_5_CATALOGUE_POSITIONS` array has been correctly expanded to include new entries for `CELLAR_RYBTC` and `CELLAR_ETH_GROWTH`.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.