Pelagicore / gdbus-codegen-glibmm

Code generator for C++ D-Bus stubs and proxies using Giomm/Glibmm
GNU Lesser General Public License v2.1
23 stars 25 forks source link

Update service example in README.md #53

Closed martin-ejdestig closed 5 years ago

martin-ejdestig commented 5 years ago

Was confusing to have connect() with a "deprecated" comment in the generated stub header and not being sure what to do instead.

martin-ejdestig commented 5 years ago

Thought about submitting a PR removing connect() entirely as well but opened #54 instead.

martin-ejdestig commented 5 years ago

Should perhaps mention that the latest version of the code that I added has not been test compiled. Will do that tomorrow if reviewer does not beat me to it. :)

martin-ejdestig commented 5 years ago

Tested and it works after fixing name of MessageHelper. Also added a commit that replaces "virtual" with "override".