search

Pelagicore / gdbus-codegen-glibmm

Code generator for C++ D-Bus stubs and proxies using Giomm/Glibmm
GNU Lesser General Public License v2.1
23 stars 25 forks source link

*MessageHelper and *TypeWrap in commoh.h.templ not namespaced #55

Closed martin-ejdestig closed 5 years ago

martin-ejdestig commented 5 years ago

Unsure why they are put in the global namespace.

Could namespace or perhaps better yet, nest TypeWrap in proxy and MessageHelper in stub.

Is it OK to change this? (Do not know what policy is with regards to backwards compatibility.) I can send a patch if it's OK and you tell me what you prefer.

I think nesting is better. I do not see why they are in common.h.templ. Not used in both proxy and stub. Am I missing something?

kursatkobya commented 5 years ago

I have checked proxies that we are used in other projects and agree with you that we do not use MessageHelper

martin-ejdestig commented 5 years ago

I am also thinking that "MessageHelper" should be renamed to e.g. "Invocation" since it wraps a Gio::DBus::MethodInvocation that itself has a get_message() method for returning a Gio::DBus::Message. (Confusing to have a thing be called the same thing as a concept that already exists but is something else.... if you know what I mean. :)

kursatkobya commented 5 years ago

I am working on this.

martin-ejdestig commented 5 years ago

I am running into problems with this now. An external project has an interface that ends with .Foo and I want to have an interface that ends with .Foo as well. Will look into picking up #59 tomorrow.

(Original problem I had was that I ran in to #57 but do not know how to fix #57 without breaking API by appending e.g. Proxy to the proxy. Or passing a custom namespace on the command line... but... ugh.)

martin-ejdestig commented 5 years ago

Fixed by #59. Closing.