Empty *_set_finish() method for properties in proxy

Pelagicore / gdbus-codegen-glibmm

Code generator for C++ D-Bus stubs and proxies using Giomm/Glibmm

GNU Lesser General Public License v2.1

23 stars 25 forks source link

Empty *_set_finish() method for properties in proxy #64

Closed martin-ejdestig closed 5 years ago

martin-ejdestig commented 5 years ago

Should they be removed? Left over from refactoring? Or are they there intentionally?

If intentional, I think a comment is in order in the body or something. It is confusing as it is now. (Do I need to call it to be future proof?)

martin-ejdestig commented 5 years ago

Since setting properties are implemented just like regular method calls to org.freedesktop.DBus.Properties I would assume this is an oversight (goes through g_dbus_proxy_call() so g_dbus_proxy_call_finish() should be used to propagate result).

martin-ejdestig commented 5 years ago

@jonte Do you know any details about this? It looks like it has been like this from the start of the project.