search

Pelagicore / meta-pelux

PELUX is an open source, GENIVI compliant development platform that supports the Qt Automotive Suite
https://pelux.io
MIT License
39 stars 28 forks source link

core-image-pelux.bbclass: add alexa sdks #269

Closed TSAnsari closed 5 years ago

TSAnsari commented 5 years ago

Signed-off-by: Tariq Ansari tansari@luxoft.com

thenor commented 5 years ago

Disregard the Taha saying this doesn't build. The build is successful https://pelux.io/jenkins/job/meta-pelux/view/change-requests/job/PR-269/

thenor commented 5 years ago

Typo in the commit message (two 'a' in packages).

sashko commented 5 years ago

Hold on, @TSAnsari! What the heck? You've forced-pushed changes after complitely different change was reviewed?

TSAnsari commented 5 years ago

Hold on, @TSAnsari! What the heck? You've forced-pushed changes after complitely different change was reviewed?

We talked about removing portaudio in this commit. Will add it in a separate commit. So that was removed. Also removed aac-sdk as it is not required for current Alexa sample app. Will add aac-sdk when it is actually used.

sashko commented 5 years ago

Hold on, @TSAnsari! What the heck? You've forced-pushed changes after complitely different change was reviewed?

We talked about removing portaudio in this commit.

I do not recall such a conversation.

TSAnsari commented 5 years ago

Hold on, @TSAnsari! What the heck? You've forced-pushed changes after complitely different change was reviewed?

We talked about removing portaudio in this commit.

I do not recall such a conversation.

TSAnsari: May be I should not add portaudio

sashko: No, you shouldn't. Only sample app should depend on it.

TSAnsari: portaudio removed

sashko commented 5 years ago

Hold on, @TSAnsari! What the heck? You've forced-pushed changes after complitely different change was reviewed?

We talked about removing portaudio in this commit.

I do not recall such a conversation.

TSAnsari: May be I should not add portaudio

sashko: No, you shouldn't. Only sample app should depend on it.

TSAnsari: portaudio removed

you've also removed aac-sdk and the entire commit message.

TSAnsari commented 5 years ago

Hold on, @TSAnsari! What the heck? You've forced-pushed changes after complitely different change was reviewed?

We talked about removing portaudio in this commit.

I do not recall such a conversation.

TSAnsari: May be I should not add portaudio sashko: No, you shouldn't. Only sample app should depend on it. TSAnsari: portaudio removed

you've also removed aac-sdk and the entire commit message.

Yes the commit message had info about portaudio and aac-sdk. So it must be changed.