Pelagicore / meta-pelux

PELUX is an open source, GENIVI compliant development platform that supports the Qt Automotive Suite
https://pelux.io
MIT License
39 stars 28 forks source link

local.conf.samples: whitelist commercial for faad2 on ARP #270

Closed sashko closed 5 years ago

sashko commented 5 years ago

faad2 is licensed under the GPLv2 and a commercial license for a commercial use, therefore LICENSE_FLAGS is set to "commercial" in the recipe.

The "commercial" license has been whitelisted for Intel and RPI3 in @49178fb4c8b2fb77. Whitelist it for ARP as well.

Signed-off-by: Oleksandr Kravchuk oleksandr.kravchuk@pelagicore.com

sashko commented 5 years ago

Fixes ARP weekly build: https://pelux.io/jenkins/job/pelux-manifests_WEEKLY/

thenor commented 5 years ago

I was confused by the "whitelist commercial for faad4" part of the commit message. Do you agree that it can be rephrased to "whitelist commercial_faad4"?

thenor commented 5 years ago

@sashko Would be nice to merge this before this week's Weekly. Do you agree with my suggested change to the commit message? It makes it more clear, I think.

thenor commented 5 years ago

@sashko Could you at least comment on my comments and answer my questions before merging?