search

Pelagicore / meta-pelux

PELUX is an open source, GENIVI compliant development platform that supports the Qt Automotive Suite
https://pelux.io
MIT License
39 stars 28 forks source link

core-image-pelux: add connectivity-manager #308

Closed martin-ejdestig closed 5 years ago

martin-ejdestig commented 5 years ago

We should probably not keep adding components unconditionally like this to core-image-pelux*.bbclass . Do it for connectivity-manager for now and then we need to come back and think about how we should handle "features" at some later point (soon (tm)).

Depends on https://github.com/Pelagicore/meta-bistro/pull/246 .

martin-ejdestig commented 5 years ago

commit message is not your personal thoughts journal

Not good to mention that it is something we should not really do? Do you want it reworded (if so, please tell me what to write) or remove it completely so that this only says "add cm"?

martin-ejdestig commented 5 years ago

Changed commit message from:

core-image-pelux: add connectivity-manager

We should probably not keep adding components unconditionally like this
to core-image-pelux*.bbclass . Do it for connectivity-manager for now and
then we need to come back and think about how we should handle "features"
at some later point (soon (tm)).

to

core-image-pelux: add connectivity-manager

Want it (https://github.com/Pelagicore/connectivity-manager) in PELUX 4.0 .
D-Bus API is not stable yet and no tagged release has been made. There
is no graphical UI using it at the moment but it can be tested from the
command line.

Not sure that adding individual components like this unconditionally to
core-image-pelux*.bbclass is something we should keep doing. Should
probably look into "distro features" (see e.g. the process-containment
feature) for the new components we are building and what we already have
added in core-image-pelux*.bbclass sometime soon.
martin-ejdestig commented 5 years ago

@sashko Do you want me to remove mention of distro features altogether?