Pelagicore / meta-pelux

PELUX is an open source, GENIVI compliant development platform that supports the Qt Automotive Suite
https://pelux.io
MIT License
39 stars 28 forks source link

Revert "Cleanup /etc/fstab handling for Intel and ARP" #354

Closed TSAnsari closed 5 years ago

TSAnsari commented 5 years ago

This reverts commit 1acf4025a35a630a572d31938ada529951d6c153.

Even though automatically generating fstab from the wks file is a nice solution, but it does not work well with the swupdate feature. The reason being that the swupdate swu file does not contain the fstab file that is generated for wic image. And there seems to be no way of updating the swu file to contain the fstab generated by wic script. So the swu file uses the base fstab from the rpi layer. This results in the partitions mounted incorrectly when the partition is updated using swupdate. So here we revert to the solution that uses hard coded fstab files instead.

sashko commented 5 years ago

what is going to be the solution?

TSAnsari commented 5 years ago

what is going to be the solution?

The solution is what this commit has reverted to.

TSAnsari commented 5 years ago

Too bad that there does not seem like there is a way to have wic generate the fstab for *.swu. :(

Only a minor nit in commit message:

So the swu file uses the base fstab from the rpi layer.

I think the default is taken from base-files in poky for Intel and ARP.

Yes. Sorry, I don't know why I was thinking about rpi. Will fix it