Pelagicore / meta-pelux

PELUX is an open source, GENIVI compliant development platform that supports the Qt Automotive Suite
https://pelux.io
MIT License
39 stars 28 forks source link

systemd: use getty-generator for vconsole instantiatiation #396

Closed sashko closed 4 years ago

sashko commented 4 years ago

systemd has a native feature that allows generation and instantiatiation of serial-getty@.service instances for virtualizer consoles.

Signed-off-by: Oleksandr Kravchuk oleksandr.kravchuk@pelagicore.com

martin-ejdestig commented 4 years ago

0390b8ae1061dceaa8cb97f13870fd9979c009a6 also added getty.target.wants to FILES_${PN}.

martin-ejdestig commented 4 years ago

I wonder why serial-getty-generator did not dynamically create getty services before in PELUX. It has been a feature in systemd for a very long time (the start of the project almost... to create them on demand and saving boot time in that way.

But if it works now, let's just remove this and be happy that we remove some services from the startup. :)

sashko commented 4 years ago

@SKumarDas do you remember why this change was brought in?

SKumarDas commented 4 years ago

@sashko This change was made to facilitate one more console because before this change we had only one and it was taken by the GUI.

sashko commented 4 years ago

No time to test this myself, but approving assuming we still get virtual consoles.

Feel free to come by my desk and check it out on NUC or Raspberry Pi I have here.