Pelagicore / meta-pelux

PELUX is an open source, GENIVI compliant development platform that supports the Qt Automotive Suite
https://pelux.io
MIT License
39 stars 28 forks source link

Move PELUX BSP layers into this layer, as sub-layers #44

Closed jonte closed 7 years ago

jonte commented 7 years ago

This ticket is meant to create a discussion around moving the PELUX BSP layers for Raspberry Pi and Intel into the meta-pelux layers.

There are several benefits of doing so:

Potential drawbacks:

What are your thoughts?

breakreturn commented 7 years ago

My input here is basically that I want to protect a few key use-cases/concerns:

Given that the above is respected, I think the technical implementation is better decided by e.g @jonte, @tobsan, @GordanM, @erikboto for example.

GordanM commented 7 years ago

@jonte, as per our discussion in person, I completely support the merge and removal of the meta-bsp layers as they seem to be more of a burden than help as it currently is. That is my technical understanding. Possibly we can mimic meta-boot2qt's pattern when it comes to including platform specific extras (http://code.qt.io/cgit/yocto/meta-boot2qt.git/tree/). It makes complete sense to me, especially because of the graphics (http://code.qt.io/cgit/yocto/meta-boot2qt.git/tree/meta-intel-extras/recipes/qt5/qtbase_git.bbappend). What do you think?

@breakreturn when it comes to the use-cases you've stated above: I would encourage a meeting to make sure we do not hinder the enabling aspect of PELUX. That is, after all, one of the main purposes of PELUX.

tobsan commented 7 years ago

The only drawback I see with this is that whenever someone builds on top of meta-pelux with a hardware of their own, they will still have to download the existing bsp data. Not sure that is a big problem, because it's not a lot of data anyway.

GordanM commented 7 years ago

@tobsan valid point. They would not have to download all the platform meta layers though, just the meta-platform-extras folder inside meta-pelux and during the configuration you would choose which platform you are targeting and the BSP would be deduced from that. So the overhead would be up to 10 or more .bb, .conf or .bbappend files.

tobsan commented 7 years ago

@GordanM Yeah, that's what I meant when saying that it isn't a lot of data :)

breakreturn commented 7 years ago

@GordanM We can have a meeting if needed, but I'm not sure if we have anything to discuss currently. I'll simply trust that the technical implementation that we end up with supports the use-cases I've listed and that they are included in the analysis.

If we need to clarify the use cases, let me know. And if we end up with design choices that are a compromise and we need to discuss priority, let me know as well.

tobsan commented 7 years ago

I think that since any user of meta-pelux will still be able to apply their own enhancements of the BSPs, this shouldn't be an issue. I'll try this out right away to see if I missed something.