search

Pelagicore / pelux-sde

PELUX Software Development Environment
Mozilla Public License 2.0
7 stars 10 forks source link

PEP8 style fixes #14

Closed gunnarx closed 6 years ago

gunnarx commented 6 years ago

Two style commits and one increasing video mem to 128MB.

I put them in one PR here for simplicity. Most important that each commit is well separated IMHO. (I'm strict about commits, not as strict on PRs, but I don't know what your policy is and if you ever go back to PRs)

1) If you want me to split the PR, let me know, or I assume you can take the parts you want.

2) These were originally on top of my previous PR but are on top of origin/master to avoid the repetition. I'd recommend therefore that you "Rebase and Merge" the PRs for a clean history. Or merge one PR, and let me know and I can rebase and push it back.

If you send review feedback I'll update.

GordanM commented 6 years ago

Thanks @gunnarx for the commit I've added some assignes to the PR so they can check it out :)

gunnarx commented 6 years ago

Since the PEP8 stuff seems to be most contested, I split the other 2 commits to a new PR which is easier to merge I guess. So we can debate this one more or reject it if you don't want it.

gunnarx commented 6 years ago

It's OK if you choose to kill this off since it's very minor. I think we have bigger axes to grind...
I have a fairly major rewrite still pending final touches. I hope to see lots of improved SDE work in cooperation (Pelux/GDP)

sashko commented 6 years ago

@DunderRoffe could you please take care of this PR? Thanks.

thenor commented 6 years ago

I think we will close this PR. We don't agree with all of the updates and we don't have the capacity in the team to take care of this at this time.