search

Pelagicore / pelux-sde

PELUX Software Development Environment
Mozilla Public License 2.0
7 stars 10 forks source link

Update SDE with DLT-viewer #7

Closed pancio88 closed 6 years ago

pancio88 commented 6 years ago

@rpannek is ok if I add to the pull request also your commits? Or I should add just my commits related to the DLT viewer? Should I add someone else to this code review?

rpannek commented 6 years ago

The first two ones are already in, so you should remove them, the merge commits should also be removed. And the labels in the Jenkinsfile are project specific too, so that should be removed also. Basically only your two commits make sense in this context I think.

pancio88 commented 6 years ago

Got it

rpannek commented 6 years ago

You shouldn't close this pull request, you should just adjust your commits in it. To do that change it in your local repo and force push it to your fork here on GitHub, this will update this pull request with the changes. Please reopen this PR.