search

Pelagicore / pelux-sde

PELUX Software Development Environment
Mozilla Public License 2.0
7 stars 10 forks source link

Feature/add dlt viewer #8

Closed pancio88 closed 6 years ago

pancio88 commented 6 years ago

Add DLT viewer and test to the SDE

breakreturn commented 6 years ago

Added @jeremiah as reviewer to support in the license and copyright related issues.

thenor commented 6 years ago

Always use the s-flag when contributing to Pelux, so that the commits are signed off.

Edit: Just saw that there isn't a Contributing.md in this project. Shouldn't there be one? Like this: https://github.com/Pelagicore/software-factory/blob/master/CONTRIBUTING.md

rpannek commented 6 years ago

Yeah, there should be. Would you mind adding it @thenor?

thenor commented 6 years ago

@rpannek I can do it. I guess just copy from another repo, like the swf? Nothing unique for this repo?

rpannek commented 6 years ago

Yeah, exactly, I think that should be enough.

breakreturn commented 6 years ago

It's been discussed previously that the "all rights reserved" is ambiguous or contradictory in the license context so this should be removed, I agree.

pancio88 commented 6 years ago

@erikboto @jeremiah @breakreturn, I change the licenses. Now the review should be fine right? I miss something else?