search

Pelagicore / software-factory

PELUX Software Factory documentation
https://pelux.io/software-factory/
GNU Lesser General Public License v2.1
9 stars 27 forks source link

building-PELUX-sources: remove image table #178

Closed fhajredini closed 5 years ago

fhajredini commented 5 years ago

The image table is hard to be read and often very confusing, this will simplify it for new users.

Signed-off-by: Fisnik Hajredini fhajredini@luxoft.com

JEderonn commented 5 years ago

I have again read through the output for this PR on Jenkins, and I have still a few comments (sorry).

  1. In wonder if you first should explain why there is a need with different build configuration variants (defined by VARIANT_NAME). Like the qt-auto variants which would add the Yocto layers with Qt Auto stuff.

  2. Then, start to explain which (minimal) images that are available on the basic configuration, followed by the qt-auto configuration variants which adds the neptune images. This would perhaps remove the duplication of the part which explains which minimal images that are available.

My impression is that it's not clear why there is a need with different (build configuration) variants. What the configuration step does (e.g. adding Yocto layers for Qt and Qt Auto and more?), and how an end-user shall know which VARIANT_NAME to use if only minimal builds are of interest.

The different options for VARIANT_NAME is not described, please do.

What do you think?

fhajredini commented 5 years ago

I have further modified the page, added more information specifically regarding variants. Expecting feedback

JEderonn commented 5 years ago

I cannot find the build on Jenkins, would be nice to have it there. Don't understand why it's not.

fhajredini commented 5 years ago

I cannot find the build on Jenkins, would be nice to have it there. Don't understand why it's not.

I think it wasnt rebased correctly. I just did it again, its currently building.

fhajredini commented 5 years ago

I will merge this by the end of the day unless there are further comments!