search

Pelican-Elegant / elegant

Best theme for Pelican Static Blog Generator
https://elegant.oncrashreboot.com/
MIT License
293 stars 187 forks source link

Check for compatibility with Pelican 4.0 #174

Closed silverhook closed 5 years ago

silverhook commented 5 years ago

Pelican 4.0 was released this month:

https://blog.getpelican.com/pelican-4.0-released.html

We should test if the theme still works as expected and what would be good changes to have in line with the the changes of the new major release of Pelican.

ashwinvis commented 5 years ago

The best (and definitely not the fastest) way to do that will be setup a continuous deployment to github pages on Travis, something like what I use here https://github.com/ashwinvis/ashwinvis.github.io/blob/develop/.travis.yml

silverhook commented 5 years ago

Super sweet idea!

@ashwinvis, would you be willing to tackle this? It’s far from urgent, but eventually we should set up things, so we scale well.

silverhook commented 5 years ago

@ashwinvis, do you think https://github.com/Pelican-Elegant/documentation/issues/1 would be a good test-case? Killing two birds with one stone, so to say.

silverhook commented 5 years ago

According to how the discussion is going on in https://github.com/Pelican-Elegant/elegant/issues/192 it might make most sense to aim a 3.x (or even very early 4.0) release as the goal to be 100% in line with Pelican 4.0.

ashwinvis commented 5 years ago

A patch like this is needed if RSS/atom feeds are enabled (something which has been overlooked in the tests and documentation, I think). Without it, it would raise a TypeError, however even with the patch and publishconf.py containing

...
FEED_ALL_ATOM = 'feeds/all.atom.xml'
CATEGORY_FEED_ATOM = 'feeds/{slug}.atom.xml'
...

categories.html rendering is not correct

-        <link href="https://fluiddyn.bitbucket.io/feeds/articles.atom.xml" type="application/atom+xml" rel="alternate" title="FluidDyn blog - Articles Category Atom Feed" />
-        <link href="https://fluiddyn.bitbucket.io/feeds/news.atom.xml" type="application/atom+xml" rel="alternate" title="FluidDyn blog - News Category Atom Feed" />
+        <link href="https://fluiddyn.bitbucket.io/feeds/{slug}.atom.xml" type="application/atom+xml" rel="alternate" title="FluidDyn blog - Articles Category Atom Feed" />
+        <link href="https://fluiddyn.bitbucket.io/feeds/{slug}.atom.xml" type="application/atom+xml" rel="alternate" title="FluidDyn blog - News Category Atom Feed" />
talha131 commented 5 years ago

@ashwinvis Would you care to open a PR for this?

iranzo commented 5 years ago

@talha131 we do have it in 'next' branch as per https://github.com/Pelican-Elegant/elegant/commit/b2397e8f9d2095952f98bcd83685ef33ec6e43fd

iranzo commented 5 years ago

We should probably try to have it released and start implementing it in 4.0 for 'master'

ashwinvis commented 5 years ago

I wasn't aware of the 'dev-*' branches. Can someone add a note on what the 'next' branch is all about in https://github.com/Pelican-Elegant/elegant/blob/master/CONTRIBUTING.md ?

iranzo commented 5 years ago

Next is used to showcase whatever is coming in next release and we use it to render the demo website (documentation in the /next ) without being limited to actual compatibility

Regards

Sent from mobile

El mar., 1 ene. 2019 7:55, Ashwin Vishnu notifications@github.com escribió:

I wasn't aware of the 'dev-*' branches. Can someone add a note on what the 'next' branch is all about in https://github.com/Pelican-Elegant/elegant/blob/master/CONTRIBUTING.md ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pelican-Elegant/elegant/issues/174#issuecomment-450713223, or mute the thread https://github.com/notifications/unsubscribe-auth/AATEjwqdZfEywqx_RBktcCPINmm9nimyks5u-wZ8gaJpZM4YtIla .

talha131 commented 5 years ago

Thank you @iranzo.

@ashwinvis Have a look at the updated guideline.

We have this confusion about master vs next branch, until we get 2.0 out of the door. After it all development will be done in next branch.

iranzo commented 5 years ago

I'm deploying my site with Pelican 4 and only issue so far is the one that we've fixed in next, has anyone done more tests?

ashwinvis commented 5 years ago

So the bug I mentioned is reproduced here:

https://travis-ci.org/Pelican-Elegant/elegant/jobs/474031399#L806

iranzo commented 5 years ago

That's failure for the w3c validator, not pelican execution (both tests succeed) :

What do you suggest for fixing it? setting the slugs/uris?

ashwinvis commented 5 years ago

I don't know :) Beats me.

iranzo commented 5 years ago

I've rebased 'next' to include latest changes in master and now we get a failure in the publishconf setup as it should:

https://travis-ci.org/Pelican-Elegant/elegant/jobs/476790279

(check for the 2nd env)

Now... we need to fix it :-)

iranzo commented 5 years ago

Thing is that error seems to come from w3c validator giving up on us, I would say that slug fails because we do use pelican 4 for this testing and it should require updated slug (on index), but the one that causes the traceback is:

INFO:w3c_validator.validator:validating: output/how-to-set-shortcut-icons.html ...

iranzo commented 5 years ago

I think we're only missing the commit for slug generation and pelican 4 for this release to happen.

I was also working on this project: https://github.com/iranzo/blog-o-matic/ that could ease this part and have other users to update to newer pelican version (either virtualenv, etc)