Pelican-Elegant / elegant

Best theme for Pelican Static Blog Generator
https://elegant.oncrashreboot.com/
MIT License
293 stars 187 forks source link

Gravatar hovercards ? #362

Closed iranzo closed 5 years ago

iranzo commented 5 years ago

I found http://en.gravatar.com/support/profile-hovercards/ while checking for something else, something we want to add?

talha131 commented 5 years ago

Our author field is much better than this. Don't you think? See #185

Pelican even has option of creating author pages.

What we can do is to fetch avatar from gravatar and show it beside author. We will probably have to make a plugin first.

iranzo commented 5 years ago

If we want to fetch from gravatar it's really easy (https://es.gravatar.com/site/implement/images/ ):

Seems that https://github.com/getpelican/pelican-plugins/tree/master/gravatar does that for us providing that data to the templates

talha131 commented 5 years ago

Good find. I have added it to the roadmap.

silverhook commented 5 years ago

How about https://www.libravatar.org/?

talha131 commented 5 years ago

We can't use gravatar plugin. It won't work with our authors field.

What we can do here is

This way user can himself decide whether he wants to use gravatar, imgur or libravatar.

iranzo commented 5 years ago

Sounds good

talha131 commented 5 years ago

cc92230769

talha131 commented 5 years ago

Guys let me know (esp. @iranzo @azzamsa) what do you think of this dict keys

    "Talha Mansoor": {
        "url": "https://www.oncrashreboot.com/",
        "blurb": "is the creator and lead developer of Elegant theme.",
        "avatar": "/images/avatars/talha131.png",
    },

specifically do you think avatar key should be replaced with something better?

I will hold on the release for few days until I hear back from you.

iranzo commented 5 years ago

Can we provide 'avatar' as 'url' ? In that case we can use gravatar or whatever we want, we can either go to gravatar and copy url from there and one file less to add to repo as static one

for example, in my case: https://es.gravatar.com/userimage/47837087/6e8d2c6bc801fb6ea9cdad090b4f5814.jpg?size=200

BTW, what about the size for the image? any limitation or does the template fixes it? (Seems 32x32 right? )

thanks

talha131 commented 5 years ago

Yes, you can give any url, gravatar or imgur or whatever.

I have fixed size to 32x32. Least distractive.

iranzo commented 5 years ago

+1 from me to merge then :)

azzamsa commented 5 years ago

Looks good to me. Github use the same thing except it has gravatar_id

"avatar_url": "https://github.com/images/error/octocat_happy.gif",
"gravatar_id": "",
talha131 commented 5 years ago

Cool. Then we are going to stay with avatar key.

talha131 commented 5 years ago

:tada: This issue has been resolved in version 3.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: