Pelican-Elegant / elegant

Best theme for Pelican Static Blog Generator
https://elegant.oncrashreboot.com/
MIT License
294 stars 187 forks source link

Remove Bootstrap #429

Open talha131 opened 5 years ago

talha131 commented 5 years ago
astraindev commented 5 years ago

Not sure if this will help but attached is a diff (against master) to use CSS only for the comments and categories.

custom.css.txt css_categories.diff.txt css_comments.diff.txt

talha131 commented 5 years ago

Thank you @andrewdstrain

About two weeks ago I tried to use radio box for accordion. It worked but the look and feel was very different. Clearly, it was more work than I expected. I pushed it down on my to do list.

It's good to see you took this task up. Thank you. Personally, I can't wait to get rid of Bootstrap.

Is it possible for you to open a PR? Our PR process has preview feature, which means anyone can see what the end result of a PR looks like. It also enables others to critic the code. Let me know if you have any issues or reservations.

We have a feature that if user directly links to a Disqus comment, we automatically open the comment accordion. The JS for it will have to be changed once we move away from Bootstrap.

astraindev commented 5 years ago

These files are much better - instead of using the "tag*" classes, they use the CSS that's already there. The main difference is the a to input/label tags. But the JavaScript might be much easier to adjust. I'll try to open a PR.

css_base.diff.txt css_categories.diff.txt css_comments.diff.txt custom.css.txt

astraindev commented 5 years ago

I did the PR.

As you can tell, the bootstrap.min.css is still in use. Only bootstrap.min.js has gone away.

And, of course, you don't have to get rid of JavaScript for menus and accordions. I'm just throwing this out there... you can do whatever you want.

talha131 commented 5 years ago

Thank you @andrewdstrain. It is definitely useful and the right step towards removing Bootstrap.

azzamsa commented 4 years ago

@talha131 I can't find the reason here why we want to remove bootstrap. it this a step towards making elengant more slim?

talha131 commented 4 years ago

For a number of reasons.

  1. We use Bootstrap 2.*. It is very old. We cant upgrade to the latest because it has a different look and defaults. The migration process is also non-trivial.
  2. The web has moved forward so much. We do not need Bootstrap or even jquery. Vanilla CSS and JS is enough for our needs.
  3. Because of Bootstrap, we are stuck in limbo. We can't upgrade Bootstrap to get bug fixes and we can't use new CSS and JS features.
  4. Boostrap is overkill for us.
  5. Upgrading Bootstrap was the issue this project stayed inactive for so long. I couldn't do it.
  6. In other progress, I have used PostCSS or SCSS. The experience is great and dev is faster.
  7. With PostCSS and SCSS, we can define a few variables and then make all components use it. For example, we can define a radius, then make all tables, code blocks, and boxes to use it. A bit more discussion is here.
azzamsa commented 4 years ago

Thank you for detailed explanation.

The web has moved forward so much. We do not need Bootstrap or even jquery. Vanilla CSS and JS is enough for our needs.

Yes, I also up vote this. This enhance our flexibility.

Hope we can get rid of it soon.

silverhook commented 1 month ago

Would this help? It seems simple, yet featureful enough(?)

https://simplecss.org/

azzamsa commented 3 weeks ago

This is better https://open-props.style/

silverhook commented 3 weeks ago

This is better https://open-props.style/

As long as we don’t fall into the same trap as with Bootstrap, I’m fine with anything :)